Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[appsync]: apikeyconfig doesnt configure if its in the AdditionalAuthenticationMode #9736

Closed
BryanPan342 opened this issue Aug 15, 2020 · 0 comments · Fixed by #9737
Closed

[appsync]: apikeyconfig doesnt configure if its in the AdditionalAuthenticationMode #9736

BryanPan342 opened this issue Aug 15, 2020 · 0 comments · Fixed by #9737
Assignees
@MrArnoldPalmer @BryanPan342
Labels
@aws-cdk/aws-appsync Related to AWS AppSync bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p2
Milestone
[DevPreview] AppSync

Comments

@BryanPan342
Copy link
Contributor

ApiKeyConfig doesn't configure to the ApiKey if its configured in additionalAuthorizationModes

aws-cdk/packages/@aws-cdk/aws-appsync/lib/graphqlapi.ts

Lines 471 to 475 in 5732b8e

const apiKeyConfig: ApiKeyConfig = props.authorizationConfig
?.defaultAuthorization?.apiKeyConfig || {
name: 'DefaultAPIKey',
description: 'Default API Key created by CDK',
};

There is no method of obtaining the api key configuration declared in additionalAuthorizationModes.

Other

This is 🐛 Bug Report
@BryanPan342 BryanPan342 added bug This issue is a bug. p2 in-progress This issue is being actively worked on. labels Aug 15, 2020
@BryanPan342 BryanPan342 self-assigned this Aug 15, 2020
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Aug 15, 2020
@BryanPan342 BryanPan342 mentioned this issue Aug 15, 2020
Merged
@MrArnoldPalmer MrArnoldPalmer added the effort/small Small work item – less than a day of effort label Aug 17, 2020
@mergify mergify bot closed this as completed in #9737 Aug 19, 2020
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@BryanPan342
fix(appsync): add dependency between apikey and schema (#9737)
4448794 
Added dependency between the CfnApiKey and CfnSchema. The dependency here is to prevent a `ConcurrencyModificationError` as seen in #8168. We allow this dependency to exist because from referencing the [docs](https://docs.aws.amazon.com/appsync/latest/APIReference/API_CreateApiKey.html#API_CreateApiKey_Errors) there shouldn't be any issue between creating an api key before or after schema creation. 

Also make ApiKeyConfig correctly configure the ApiKey when used in `additionalAuthorizationModes`.

Fixes #9736
Fixes #8168 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

@BryanPan342 BryanPan342

Labels
@aws-cdk/aws-appsync Related to AWS AppSync bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[DevPreview] AppSync
Development

Successfully merging a pull request may close this issue.

fix(appsync): add dependency between apikey and schema BryanPan342/aws-cdk
2 participants
@MrArnoldPalmer @BryanPan342