fix(cloudfront): Distribution does not add edgelambda trust policy #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stable `CloudFrontWebDistribution` construct automatically adds the 'edgelambda.amazonaws.com' trust policy to the Lambda execution role when adding a Lambda@Edge function to the distribution. The newer `Distribution` construct was missing this functionality. Also added an integ test to validate the Lambda@Edge functions can actually be deployed. fixes #9998
njlynch
force-pushed
the
njlynch/cf-edgelambda-execution
branch
from
4db0a50
to
312318c
Compare
|
@njlynch I was just about to create this issue. Thank you!! 🤟 |
rix0rrr
approved these changes
Aug 28, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stable
CloudFrontWebDistributionconstruct automatically adds the'edgelambda.amazonaws.com' trust policy to the Lambda execution role when
adding a Lambda@Edge function to the distribution. The newer
Distributionconstruct was missing this functionality.
Also added an integ test to validate the Lambda@Edge functions can actually be
deployed.
fixes #9998
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license