Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appsync): add authorization config to the HttpDataSource #10171

Merged
merged 9 commits into from
Sep 8, 2020
Merged

feat(appsync): add authorization config to the HttpDataSource #10171

merged 9 commits into from
Sep 8, 2020

Conversation

haruharuharuby
Copy link
Contributor

@haruharuharuby haruharuharuby commented Sep 4, 2020 •
edited by BryanPan342
Loading

This PR supersedes #9971

Description

Adding authorization config to HttpDatasource in aws-appsync module.
Users will be able to specify the awsIamConfig in httpConfig as parameter of HttpDataSource.

Fixes: #9934

@haruharuharuby haruharuharuby mentioned this pull request Sep 4, 2020
Closed
4 tasks
BryanPan342
BryanPan342 reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@BryanPan342 BryanPan342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final touches!

packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appsync/README.md Outdated Show resolved Hide resolved
@BryanPan342 BryanPan342 self-assigned this Sep 4, 2020
@BryanPan342 BryanPan342 added the @aws-cdk/aws-appsync Related to AWS AppSync label Sep 4, 2020
haruharuharuby and others added 5 commits September 5, 2020 05:34
@haruharuharuby @BryanPan342
Update packages/@aws-cdk/aws-appsync/README.md
2a7cc13 
Co-authored-by: Bryan Pan <bryanpan342@gmail.com>
@haruharuharuby @BryanPan342
Update packages/@aws-cdk/aws-appsync/README.md
bc50431 
Co-authored-by: Bryan Pan <bryanpan342@gmail.com>
@haruharuharuby @BryanPan342
Update packages/@aws-cdk/aws-appsync/README.md
15273f0 
Co-authored-by: Bryan Pan <bryanpan342@gmail.com>
@haruharuharuby @BryanPan342
Update packages/@aws-cdk/aws-appsync/README.md
d0932b1 
Co-authored-by: Bryan Pan <bryanpan342@gmail.com>
@haruharuharuby @BryanPan342
Update packages/@aws-cdk/aws-appsync/README.md
4db7328 
Co-authored-by: Bryan Pan <bryanpan342@gmail.com>
@haruharuharuby
Copy link
Contributor Author

@BryanPan342 thank you final check!

BryanPan342
BryanPan342 previously approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@BryanPan342 BryanPan342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thanks for the contribution @haruharuharuby 😊

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed BryanPan342’s stale review September 8, 2020 17:40

Pull request has been modified.

BryanPan342
BryanPan342 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@BryanPan342 BryanPan342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a weird bug in s3-deployment but this should work :)

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 757c0bb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b2cc277 into aws:master Sep 8, 2020
@haruharuharuby
Copy link
Contributor Author

Thanks again many supports. :) @BryanPan342

@andrestone
Copy link
Contributor

Does anyone know what are the values expected by signingServiceName? It's completely obscure if this refers to the ARN standard or the endpoint subdomain. No clue at the documentation either.

@cm-wada-yusuke cm-wada-yusuke mentioned this pull request Oct 29, 2020
Merged
mergify bot pushed a commit that referenced this pull request Nov 10, 2020
@cm-wada-yusuke
fix(appsync): HttpDataSource extends BackedDataSource instead of Base…
4b4d011 
…DataSource (#11185)

BackedDataSource make Grantable HttpDataSource.  I think this pr allows better use of the iam config: #10171

fixes #11183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanPan342 BryanPan342 BryanPan342 approved these changes

Assignees
No one assigned
Labels
@aws-cdk/aws-appsync Related to AWS AppSync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-appsync] Adding AuthorizationConfig within construction HttpDataSource of the appsync module.
4 participants
@haruharuharuby @aws-cdk-automation @andrestone @BryanPan342