Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): move expiration from s3-deployments into core #10192

Merged
merged 13 commits into from
Sep 8, 2020
Merged

refactor(core): move expiration from s3-deployments into core #10192

merged 13 commits into from
Sep 8, 2020

Conversation

BryanPan342
Copy link
Contributor

@BryanPan342 BryanPan342 commented Sep 4, 2020 •
edited
Loading

Move Expires class from s3-deployments to core. Rename to Expiration

BREAKING CHANGE: s3-deployments property expires takes cdk.Expiration instead of  Expires

  • s3-deployments: BucketDeploymentProps.expires now takes in type cdk.Expiration

Note: PR separated from #9122

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BryanPan342 BryanPan342 requested review from eladb and iliapolo and removed request for eladb September 4, 2020 20:24
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 4, 2020
@BryanPan342 BryanPan342 self-assigned this Sep 4, 2020
@BryanPan342 BryanPan342 added @aws-cdk/core Related to core CDK functionality @aws-cdk/aws-s3-deployment labels Sep 4, 2020
@BryanPan342 BryanPan342 mentioned this pull request Sep 4, 2020
Merged
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1dfd24c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0e6e3c3 into aws:master Sep 8, 2020
@BryanPan342 BryanPan342 deleted the expires branch September 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

@eladb eladb Awaiting requested review from eladb

Assignees

@BryanPan342 BryanPan342

Labels
@aws-cdk/aws-s3-deployment @aws-cdk/core Related to core CDK functionality contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BryanPan342 @aws-cdk-automation @iliapolo