Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app-delivery): CI/CD for CDK Stacks #1022
feat(app-delivery): CI/CD for CDK Stacks #1022
Changes from 2 commits
c2d6100
2c5e17b
4acd48e
bdc1adb
e9abecf
79b0816
84bb2f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this experience.
Project
incodebuild
can also use an inline build spec. Should we put this logic in some reusable utility methods that encapsulate this logic for the languages the CDK supports? A separate method for TypeScript / JavaScript, Java, .NET, etc.These can be 'fallback' instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I guess I can provide some canned buildspecs. I'll have a look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into the canned buildspecs, I realized that it gets awkward once the build image needs to support the buildspec, especially when the standard CodeBuild images don't ... For example, if I want to make a buildspec for a Java CDK project, I'd need to be able to provide an image that has
node
and a JDK... Right now I'd have to limit support to TypeScript & Javascript, which feels too restrictive.