chore: don't have mergify delete branches #10264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branches are automatically deleted by GitHub itself, so Mergify doesn't have to do that. In fact, Mergify trying to do it leaves the end result of every closed PR with a failing "cross" icon because the Mergify action to delete the head branch fails.
njlynch
approved these changes
Sep 9, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
previously requested changes
Sep 9, 2020
|
Just saw your comment in the chat about GH doing this automatically. If that's so, I'm ok with this change. |
|
I said that in the PR description as well. |
|
Sorry :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branches are automatically deleted by GitHub itself, so Mergify doesn't
have to do that.
In fact, Mergify trying to do it leaves the end result of every
closed PR with a failing "cross" icon because the Mergify action
to delete the head branch fails.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license