fix(cli): cdk synth fails if AWS_ credentials have expired
#10343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are credentials but using them fails, the "default account lookup" that's used to populate the environment variables fails (should have returned `undefined`) and the CLI aborts before the CDK app is synth'ed. Fixes #7849.
rix0rrr
changed the title
cdk synth fails if AWS_ credentials are expiredcdk synth fails if AWS_ credentials have expired
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
njlynch
approved these changes
Sep 14, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Sep 15, 2020
To prevent future errors like #10343, add a linting rule that would have caught that bug. The use of this linting rule requires normalizing code in multiple places.
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2020
To prevent future errors like #10343, add a linting rule that would have caught that bug. The use of this linting rule requires normalizing code in multiple places, there's no wait to only positively check for one case. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are credentials but using them fails, the "default account
lookup" that's used to populate the environment variables fails
(should have returned
undefined) and the CLI aborts before the CDKapp is synth'ed.
Fixes #7849.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license