Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update module description to align with other modules #10383

Merged
merged 3 commits into from
Sep 16, 2020

Conversation

shivlaks
Copy link
Contributor

modifying the description to match what we currently use when we create
libraries for new services.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

modifying the description to match what we currently use when we create
libraries for new services.
@shivlaks shivlaks self-assigned this Sep 16, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 16, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be that guy....

% cd packages/@aws-cdk/
% package_descriptions=$(find . -maxdepth 2 -name 'package.json' | xargs jq .description)
% echo $package_descriptions | grep -c 'CDK Constructs for'
23
%  echo $package_descriptions | grep -c 'The CDK Construct Library for'
100

If we're going to fix this one, we might as well fix the other 22, right? :D

@shivlaks
Copy link
Contributor Author

I'm going to be that guy....

% cd packages/@aws-cdk/
% package_descriptions=$(find . -maxdepth 2 -name 'package.json' | xargs jq .description)
% echo $package_descriptions | grep -c 'CDK Constructs for'
23
%  echo $package_descriptions | grep -c 'The CDK Construct Library for'
100

If we're going to fix this one, we might as well fix the other 22, right? :D

we should, and thanks for being that guy! - will udpate

@shivlaks shivlaks changed the title chore(cloudfront): update module description to align with other modules chore: update module description to align with other modules Sep 16, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going the extra mile! :D

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 57f0798
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9e4451a into master Sep 16, 2020
@mergify mergify bot deleted the shivlaks/cloudfront-description branch September 16, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants