chore: fix integ tests #10384
Merged
chore: fix integ tests #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed passing the new required `--cloudformation-execution-policies` argument in a couple of tests, and ignore the backwards compatibility tests that don't pass it yet.
shivlaks
previously requested changes
Sep 16, 2020
Comment on lines
7
to
10
| add tags, left alone on re-bootstrap | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| add tags, left alone on re-bootstrap | |
| add tags, left alone on re-bootstrap |
just dropping some extra newlines :)
| '--qualifier', fixture.qualifier, | ||
| '--cloudformation-execution-policies', 'arn:aws:iam::aws:policy/AdministratorAccess'], { | ||
| modEnv: { CDK_NEW_BOOTSTRAP: '1' }, | ||
| }); | ||
| await fixture.cdk(['bootstrap', '-v', '--toolkit-stack-name', bootstrapStackName, '--force'], { modEnv: { CDK_NEW_BOOTSTRAP: '1' } }); |
There was a problem hiding this comment.
does this also need to be updated to include --cloudformation-execution-policies - assuming the test is intending to only switch on the --termination-protection flag
shivlaks
approved these changes
Sep 16, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed passing the new required
--cloudformation-execution-policiesargument in a couple of tests, and ignore the backwards compatibility
tests that don't pass it yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license