chore(awslint): rules permit constructs to extend from 'constructs' module #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 21, 2020 17:43
added 2 commits
September 22, 2020 11:03
nija-at
force-pushed
the
nija-at/change-construct-interface
branch
from
0b63043
to
c2a8405
Compare
eladb
suggested changes
Sep 22, 2020
added 5 commits
September 23, 2020 10:38
nija-at
changed the title
eladb
approved these changes
Sep 23, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an environment variable -
AWSLINT_BASE_CONSTRUCTrecognized by
awslint. This environment variable indicates that themodule has migrated away from construct classes and
interfaces from
@aws-cdk/coremodule to those inconstructsmodule.
Specific rules in the linter recognize this variable and modify their
expectations.
Motivation
The primary motivation is to move the code base towards removal of the
construct compat layer as part of CDKv2.
A large number of code changes to adopt "constructs" module can already
be done as part of CDKv1 without incurring breaking changes to the API.
This change enables these changes to be performed module-by-module. As
modules are migrated, this flag will be enabled, to ensure no
regression.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license