feat(cloudfront-origins): customize origin access identity in s3origin #10491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtho
force-pushed
the
wtho/s3origin-access-identifier
branch
from
e9e3c07
to
0837ad3
Compare
njlynch
reviewed
Oct 5, 2020
packages/@aws-cdk/aws-cloudfront-origins/test/integ.s3-origin-oai.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-cloudfront-origins/test/s3-origin.test.ts
Outdated
Show resolved
Hide resolved
wtho
force-pushed
the
wtho/s3origin-access-identifier
branch
from
0837ad3
to
960f7ba
Compare
Adds support for passing in a identity as it is possible in the CloudFrontWebDistribution closes aws#9859
wtho
force-pushed
the
wtho/s3origin-access-identifier
branch
from
960f7ba
to
50bc0f6
Compare
njlynch
approved these changes
Oct 7, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing in a identity as it is possible in the CloudFrontWebDistribution
closes #9859
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license