-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cfnspec): cloudformation spec v18.4.0 #10493
Conversation
Need to add ApiEndpoint as an attribute to |
* AWS::ECS::Service.NetworkConfiguration AwsvpcConfiguration (__deleted__) | ||
* AWS::ECS::Service.NetworkConfiguration AwsVpcConfiguration (__added__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context: aws-cloudformation/cfn-lint#1706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned in the issue, since the ECS
resource is deployed in the CloudFormation Registry, its property types are case insensitive. Changing this now might result in resource replacement for existing users, we have seen something similar in #10201 (comment). Given this works now, and changing it might result in a breaking change, wouldn't be better to keep the previous casing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this works now, and changing it might result in a breaking change, wouldn't be better to keep the previous casing?
Seems better if ECS switches back to the original casing. Part of why I called out that context. The casing shouldn't have been changed in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… not yet exposed through the CDK
…on to avoid breaking ECS users
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
No description provided.