Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cfnspec): add junit.xml to ignore files #10566

Merged
merged 3 commits into from
Sep 29, 2020
Merged

chore(cfnspec): add junit.xml to ignore files #10566

merged 3 commits into from
Sep 29, 2020

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Sep 28, 2020 •
edited
Loading

When generating a new module, add junit.xml to .npmignore and .gitignore, this is required by aws-lint rule.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 28, 2020
@NetaNir NetaNir requested a review from a team September 28, 2020 06:54
@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Sep 28, 2020
shivlaks
shivlaks approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mark this as a chore.
Can you also add the motivation as well in the commit body: (i.e. we added junit.xml to gitignore to support test reports and we missed adding it when creating new libraries from the spec import`)

@NetaNir NetaNir changed the title fix(cfnspec): add junit.xml to ignore files chore(cfnspec): add junit.xml to ignore files Sep 29, 2020
@NetaNir NetaNir removed the pr/do-not-merge This PR should not be merged at this time. label Sep 29, 2020
@NetaNir
Copy link
Contributor Author

NetaNir commented Sep 29, 2020

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Command refresh: success

shivlaks
shivlaks approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@NetaNir
Copy link
Contributor Author

NetaNir commented Sep 29, 2020

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Command update: success

Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 31f8256
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 37723e9 into master Sep 29, 2020
@mergify mergify bot deleted the neta/cfnspec-ignore-junit-files branch September 29, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NetaNir @aws-cdk-automation @shivlaks