fix(s3-deployment): User metadata was added with wrong prefix (x-amzn-meta-) #10678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
changed the title
iliapolo
approved these changes
Oct 8, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2021
…prefix (#12414) Without this fix, keys are prefixed with x-amzn-meta- by the TypeScript code, then the Python code runs and prefixes metadata keys again with x-amz-meta-. Then, the Python shells out to aws-cli which makes a request to the S3 service. There, the keys are prefixed *yet again* with x-amz-meta- _unconditionally_. Thus no matter what keys the user specified, the keys in S3 would be: x-amz-meta-x-amz-meta-x-amzn-meta-<user input>. This issue was originally reported as #8459. #10678 attempted to fix this issue, and fixed the Python, but missed the TS. It also suffers from the S3 service adding the prefix unconditionally. After this change, neither the TypeScript code nor the Python code will attempt to prepend to the metadata key. Instead we rely on the S3 service to do it. BREAKING CHANGE: User metadata keys of bucket objects will change from `x-amz-meta-x-amz-meta-x-amzn-meta-mykey` to `x-amz-meta-mykey`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mohanrajendran
pushed a commit
to mohanrajendran/aws-cdk
that referenced
this pull request
Jan 24, 2021
…prefix (aws#12414) Without this fix, keys are prefixed with x-amzn-meta- by the TypeScript code, then the Python code runs and prefixes metadata keys again with x-amz-meta-. Then, the Python shells out to aws-cli which makes a request to the S3 service. There, the keys are prefixed *yet again* with x-amz-meta- _unconditionally_. Thus no matter what keys the user specified, the keys in S3 would be: x-amz-meta-x-amz-meta-x-amzn-meta-<user input>. This issue was originally reported as aws#8459. aws#10678 attempted to fix this issue, and fixed the Python, but missed the TS. It also suffers from the S3 service adding the prefix unconditionally. After this change, neither the TypeScript code nor the Python code will attempt to prepend to the metadata key. Instead we rely on the S3 service to do it. BREAKING CHANGE: User metadata keys of bucket objects will change from `x-amz-meta-x-amz-meta-x-amzn-meta-mykey` to `x-amz-meta-mykey`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref
closes #8459
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license