feat(aws-codepipeline): don't poll by default in GitHubSourceAction #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
suggested changes
Nov 4, 2018
skinny85
changed the title
skinny85
changed the title
skinny85
force-pushed
the
feature/github-action-webhooks
branch
from
7dd2bc4
to
25eedf1
Compare
|
Rebased and updated the comment to reflect there is no need for a manual step. |
…ult for the GitHub source Action.
skinny85
force-pushed
the
feature/github-action-webhooks
branch
from
25eedf1
to
9454490
Compare
|
Missed an integ test for |
eladb
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually by granting GitHub permissions to one of my repositories (this one).
Part of changes from #1030.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.