Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redshift): Allow redshift cluster securityGroupName to be generated #10742

Merged
merged 3 commits into from
Oct 7, 2020
Merged

fix(redshift): Allow redshift cluster securityGroupName to be generated #10742

merged 3 commits into from
Oct 7, 2020

Conversation

mitchlloyd
Copy link
Contributor

@mitchlloyd mitchlloyd commented Oct 6, 2020 •
edited by SomayaB
Loading

PR that resolves #10740

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@SomayaB SomayaB changed the title Allow redshift cluster securityGroupName to be generated fix(redshift): Allow redshift cluster securityGroupName to be generated Oct 6, 2020
njlynch
njlynch previously approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mergify mergify bot dismissed njlynch’s stale review October 7, 2020 10:37

Pull request has been modified.

@njlynch njlynch added the pr-linter/exempt-test The PR linter will not require test changes label Oct 7, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f9449b4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit effed09 into aws:master Oct 7, 2020
njlynch pushed a commit that referenced this pull request Oct 7, 2020
@mitchlloyd @njlynch
fix(redshift): Allow redshift cluster securityGroupName to be generat…
84d354d 
…ed (#10742)

PR that resolves #10740

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mitchlloyd mitchlloyd deleted the generate-redshift-sg-name branch October 7, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

Assignees

@njlynch njlynch

Labels
pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[redshift] Cannot create more than 1 redshift cluster due to hard-coded security group name
3 participants
@mitchlloyd @aws-cdk-automation @njlynch