Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monocdk-experiment): rename package name to monocdk #10743

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Oct 6, 2020

Renaming monocdk-experiment to monocdk.

This change does not change the stability of the package, it is still experimental, and not recommended for use by the external community.

Notes:

  • This change means that we are deprecating monocdk-experiment.
  • Currently we are not renaming @monocdk-experiment\assert.
  • The rewrite script was modified to use monocdk. Next PR will add the capability to specify the name of the monolithic package used.

BREAKING CHANGES: monocdk-experiment is now deprecated


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NetaNir NetaNir requested a review from a team October 6, 2020 21:03
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 6, 2020
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the workspaces key in package.json also need to be updated

"packages/@monocdk-experiment/*", -> "packages/@monocdk/*",

there's also a reference in lerna.json that might need updating

@NetaNir
Copy link
Contributor Author

NetaNir commented Oct 6, 2020

does the workspaces key in package.json also need to be updated

"packages/@monocdk-experiment/*", -> "packages/@monocdk/*",

No, we are not changing the name of the packages under @monocdk-experiment, only monocdk-experiment-> monocdk

@shivlaks
Copy link
Contributor

shivlaks commented Oct 6, 2020

does the workspaces key in package.json also need to be updated
"packages/@monocdk-experiment/*", -> "packages/@monocdk/*",

No, we are not changing the name of the packages under @monocdk-experiment, only monocdk-experiment-> monocdk

thanks for clarifying!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8d3b3ba
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@NetaNir NetaNir merged commit c4fe494 into master Oct 6, 2020
@NetaNir NetaNir deleted the neta/monocdk branch October 6, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants