Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): cannot configure stage for SpecRestApi #10749

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

alvyn279
Copy link
Contributor

@alvyn279 alvyn279 commented Oct 7, 2020


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

nija-at
nija-at previously approved these changes Oct 15, 2020
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@alvyn279
Copy link
Contributor Author

@nija-at Do I resolve conflicts on my branch and push it? Or I'm not the one who's supposed to resolve the conflicts ?

@nija-at
Copy link
Contributor

nija-at commented Oct 16, 2020

@alvyn279 - yes, the PR author is expected to resolve conflicts and update the PR.

- Expects generic `RestApiBase` instead of `RestApi` at `BasePathMapping` creation
- Fixes aws#10300
@gitpod-io
Copy link

gitpod-io bot commented Oct 16, 2020

@mergify mergify bot dismissed nija-at’s stale review October 16, 2020 17:32

Pull request has been modified.

@alvyn279 alvyn279 requested a review from nija-at October 16, 2020 18:47
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3a7becf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 62a2286 into aws:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-apigateway] BasePathMapping does not configure stage for SpecRestApi with domainName
3 participants