-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apigateway): cannot configure stage for SpecRestApi #10749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@nija-at Do I resolve conflicts on my branch and push it? Or I'm not the one who's supposed to resolve the conflicts ? |
@alvyn279 - yes, the PR author is expected to resolve conflicts and update the PR. |
- Expects generic `RestApiBase` instead of `RestApi` at `BasePathMapping` creation - Fixes aws#10300
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
RestApiBase
instead ofRestApi
atBasePathMapping
creationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license