Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cfnspec): drop step functions patch as the updated spec has restored properties #10764

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Oct 7, 2020

in the 18.5 import, there the AWS::StepFunctions::Activity resource dropped the required
name property and added one called Arn which was unintentional. A patch was added to restore
the resource specification to previous state.

Since #10762 has been merged, those properties have been restored in the resource specification
as of 18.6. The patch is no longer necessary.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…tored properties

in the `18.5` import, there the AWS::StepFunctions::Activity resource dropped the required
name property and added one called Arn which was unintentional. A patch was added to restore
the resource specification to previous state.

Since #10762 has been merged, those properties have been restored in the resource specification
as of `18.6`. The patch is no longer necessary.
@shivlaks shivlaks requested a review from a team October 7, 2020 11:37
@shivlaks shivlaks self-assigned this Oct 7, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 7, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b174f4c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1123f07 into master Oct 7, 2020
@mergify mergify bot deleted the shivlaks/drop-cfnspec-patch branch October 7, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants