feat(eks): IAM Roles for service accounts in imported clusters

[aka-toxa]

Hi this is a try to fix #10601
I didn't add proper documentation and tests now because discussions about how to implement that are stale so I've decided to push it forward by creating this PR

if you guys think this is a good approach I will proceed with the unit tests and proper documentation

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[iliapolo]

@aka-toxa General approach is good. See my comments. And thanks! :)

Pull request has been modified.

Pull request has been modified.

[aka-toxa]

hey @iliapolo can you please help me with the failed build? I'm not sure I understand what it wants from me :(

[gitpod-io]

[iliapolo]

@aka-toxa I think its something to do with version numbers in lerna.json and an update from master should resolve it.
i've updated the branch, lets see if it works - Im digging a little deeper in the meantime.

[aka-toxa]

@iliapolo it looks like that merging the master branch helps

can you check your prev. comments again please? I've resolved most of them

[aka-toxa]

issuer and issuer url is the same thing.
in AWS console there is no separated fields, but only one

[iliapolo]

issuer and issuer url is the same thing.
in AWS console there is no separated fields, but only one

But in the code you explicitly separate the https://.

https://github.com/aka-toxa/aws-cdk/blob/aka-toxa/irsa-support-for-imported-clusters/packages/@aws-cdk/aws-iam/lib/oidc-provider.ts#L168

That means that clusterOpenIdConnectIssuerUrl will not actually return a URL, i.e it won't have the https:// prefix. No?

Pull request has been modified.

[aka-toxa]

hi @iliapolo
I'm back
Stan merged his branch to my original PR and I've looked through your last review here and resolved comments that was already addressed. there are still two comments needed discussion.

let decide what we do next?

[aka-toxa]

@iliapolo done.

[iliapolo]

@aka-toxa Thanks for the hard work! Greatly appreciated :)

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 97b6983
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).