fix(cli): deployments are skipped if stack is in a _failed state #10847
Conversation
|
|
eswets
force-pushed
the
eswets/dont-skip-deploy-on-failed-state
branch
from
14bddd7
to
400daeb
Compare
| }).catch(e => err = e); | ||
|
|
||
| // THEN | ||
| expect(err).toEqual(Error('The stack named withouterrors failed to deploy: DELETE_FAILED')); |
There was a problem hiding this comment.
It's not clear to me why this is the correct test for this behavior change.
Don't we want to assert that "createChangeSet" is called, or something to that effect?
There was a problem hiding this comment.
I've pushed a change to the test asserting a call on createChangeSet, however i'm not sure that in that case the expected behaviour is fully captured by the test.
Currently, the stack will actually deploy, after which waitForStackDeploy will throw an error due to the stack not being in a success state.
rix0rrr
changed the title
rix0rrr
changed the title
eswets
force-pushed
the
eswets/dont-skip-deploy-on-failed-state
branch
from
400daeb
to
095a663
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes #10784
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license