Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events-targets): allow passing a role to the CodeBuild target #10865

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

newcomer
Copy link
Contributor

@newcomer newcomer commented Oct 14, 2020

fixes #10866


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2020

@newcomer newcomer changed the title feat(events): allow passing a role to the CodeBuild target feat(aws-events-targets): allow passing a role to the CodeBuild target Oct 14, 2020
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @newcomer !

@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 14, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 changed the title feat(aws-events-targets): allow passing a role to the CodeBuild target feat(events-targets): allow passing a role to the CodeBuild target Oct 14, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f3fb56f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f085a09 into aws:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeBuildProject to support custom role
3 participants