Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 'test/' to npmignore when creating missing construct libraries #10871

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

shivlaks
Copy link
Contributor

following on from changes made in #10728, added the 'test/' entry to
npmignore when creating new construct library modules.

rationale: we stopped bundling test directories to reduce package sizes
and prevent yarn from unplugging some packages based on presence of a
'.jar' file


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ries

following on from changes made in #10728, added the 'test/' entry to
npmignore when creating new construct library modules.

rationale: we stopped bundling test directories to reduce package sizes
and prevent yarn from unplugging some packages based on presence of a
'.jar' file
@shivlaks shivlaks added the package/tools Related to AWS CDK Tools or CLI label Oct 14, 2020
@shivlaks shivlaks requested a review from a team October 14, 2020 17:28
@shivlaks shivlaks self-assigned this Oct 14, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2020

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 14, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1fc100e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a4bab5b into master Oct 14, 2020
@mergify mergify bot deleted the shivlaks/create-missing-libraries-npmignore branch October 14, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants