fix(cli): Python id parameter in init template conflicts with built-in
#10874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rix0rrr
changed the title
rix0rrr
requested changes
Oct 19, 2020
ericzbeard
requested review from
RomainMuller
and removed request for
RomainMuller
ericzbeard
changed the title
rix0rrr
requested changes
Oct 26, 2020
| @@ -1,9 +1,9 @@ | |||
| from aws_cdk import core | |||
|
|
|||
|
|
|||
| class %name.PascalCased%Stack(core.Stack): | |||
| class % name.PascalCased % Stack(core.Stack): | |||
There was a problem hiding this comment.
These autoformats are going to break things I believe.
ericzbeard
added
the
pr/work-in-progress
rix0rrr
approved these changes
Oct 28, 2020
rix0rrr
changed the title
rix0rrr
changed the title
id parameter conflicts with built-in
rix0rrr
changed the title
id parameter conflicts with built-inid parameter in init template conflicts with built-in
rix0rrr
added
the
pr-linter/exempt-test
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python,
id()is a builtin function that can cause linter warnings and some confusion while developing stacks in Python. This change simply renamesidtostack_idin the init template.