-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda-nodejs): docker build is not working #10885
Conversation
`lib/bundlers.ts` actually uses not `sh` but `bash`, `bash` is a good way to test.
aws-lambda-nodejs have issue * [npm install -g yarn · Issue #6 · nodejs/corepack](nodejs/corepack#6) * [npm install yarn --global fails in docker container · Issue aws#8358 · yarnpkg/yarn](yarnpkg/yarn#8358) From issue comment, > For future reference, you can (should) pin your version rather than use whatever the latest is on npm (by using yarn@1.22.6, etc) - it's a good practice anyway regardless of the conditions, as you never know which bug could slip by us. You can also use the yarn-path setting to ensure that upgrades go through the appropriate review processes (including CI). > > <yarnpkg/yarn#8358 (comment)> So we'll follow it. And from issue comment, > Fwiw we don't plan to add any more features to Yarn 1, as all of our resources have shifted to Yarn 2. The past few commits have been aimed toward making the transition a bit easier, in particular thanks to the Corepack initiative which we hope will make it easier to use Yarn (both 1 & 2) by removing the need to manually install them. > > <yarnpkg/yarn#8358 (comment)> There's not much need to be concerned with the latest version of 1.
`amazon/aws-sam-cli-build-image-nodejs12.x` don't have user that index is 1000. So create non root user. `/` in `amazon/aws-sam-cli-build-image-nodejs12.x` permission is `700`. change to allow execute command for non root user. I really don't want to change around the permissions, but I don't have a choice.
@ncaq what do you mean exactly here? |
The
So test code use bash likewise.
|
@jogold awaiting your LGTM |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes #10881
fix from sh to bash
lib/bundlers.ts
actually uses notsh
butbash
,bash
is a good way to test.lock yarn version
aws-lambda-nodejs have issue
From issue comment,
So we'll follow it.
And from issue comment,
There's not much need to be concerned with the latest version of 1.
allow execute command for non root user
amazon/aws-sam-cli-build-image-nodejs12.x
don't have user that index is 1000.So create non root user.
/
inamazon/aws-sam-cli-build-image-nodejs12.x
permission is700
.change to allow execute command for non root user.
I really don't want to change around the permissions,
but I don't have a choice.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license