feat(lambda-event-sources): disable source mapping #10927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wtho
force-pushed
the
wtho/event-sources-enabled-field
branch
from
58d2b43
to
2c24026
Compare
nija-at
changed the title
enabled
nija-at
changed the title
nija-at
previously requested changes
Oct 21, 2020
wtho
force-pushed
the
wtho/event-sources-enabled-field
branch
from
2c24026
to
3292d00
Compare
Specifically, it enables this flag in the props of which resources use an underlying Cfn EventSourceMapping, which carries the Enabled flag itself. These are currently: SQS, DynamoDb Streams and Kinesis. Closes aws#5750
wtho
force-pushed
the
wtho/event-sources-enabled-field
branch
from
bd5e165
to
b3af8fb
Compare
nija-at
reviewed
Oct 23, 2020
nija-at
previously approved these changes
Oct 23, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
nija-at
approved these changes
Oct 23, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, it enables this flag in the props of which resources use
an underlying Cfn EventSourceMapping, which carries the Enabled flag
itself.
These are currently: SQS, DynamoDb Streams and Kinesis.
MSK is also listed in the Cfn Docs, but I could not find MSK in
lambda-event-sources.Closes #5750
README.mdThis change is not breaking.
I did not add integration tests so far, but could write some if required.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license