chore(eks): relax cdk8s dependency to constructs + runtime validation #10933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iliapolo
commented
Oct 18, 2020
|
|
||
| const cdk8sChart = chart as any; | ||
|
|
||
| if (typeof cdk8sChart.toJson !== 'function') { |
There was a problem hiding this comment.
I didn't add a naive constructor validation since it will fail for custom charts that extend cdk8s.Chart. A more complex validation might be worth while but we can add that later on.
For now I think this will suffice.
eladb
approved these changes
Oct 18, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid forcing a
cdk8sdependency on the monolithic packages, we don't directly usecdk8s.Chartin the EKS integration. Instead, we use a genericConstructand assert at runtime that it indeed a cdk8s chart.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license