Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(s3): migrate tests to jest #10934

Merged
merged 2 commits into from
Oct 20, 2020
Merged

chore(s3): migrate tests to jest #10934

merged 2 commits into from
Oct 20, 2020

Conversation

Chriscbr
Copy link
Contributor

One test was modified because the last argument didn't type check against the nodeunit-shim - here:

test.throws(() => new s3.Bucket(stack, 'MyBucket', {
bucketName: bucket,
}), function(err: Error) {
return expectedErrors === err.message;
});

changed to:

test.throws(() => new s3.Bucket(stack, 'MyBucket', {
  bucketName: bucket,
}), expectedErrors);

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2020

Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks @Chriscbr

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9e04c9d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 585920e into aws:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants