Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cognito): README touch-ups #10993

Merged
merged 13 commits into from
Oct 23, 2020
Merged

docs(cognito): README touch-ups #10993

merged 13 commits into from
Oct 23, 2020

Conversation

shivlaks
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks shivlaks added the @aws-cdk/aws-cognito Related to Amazon Cognito label Oct 20, 2020
@shivlaks shivlaks requested a review from nija-at October 20, 2020 17:00
@shivlaks shivlaks self-assigned this Oct 20, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 20, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 21, 2020 •
edited
Loading

nija-at
nija-at previously requested changes Oct 22, 2020
View reviewed changes
@shivlaks shivlaks requested a review from nija-at October 22, 2020 08:57
@shivlaks shivlaks dismissed nija-at’s stale review October 22, 2020 10:25

addressed feedback

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Oct 23, 2020
nija-at
nija-at approved these changes Oct 23, 2020
View reviewed changes
shivlaks and others added 2 commits October 23, 2020 07:33
@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label Oct 23, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 376dc91
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0d92242 into master Oct 23, 2020
@mergify mergify bot deleted the shivlaks/cognito-readme branch October 23, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@shivlaks shivlaks

Labels
@aws-cdk/aws-cognito Related to Amazon Cognito contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivlaks @aws-cdk-automation @nija-at