Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-rds/aws-secretmanager): input type of credentials.fromSecret #11033

Merged
merged 4 commits into from
Oct 26, 2020
Merged

fix(aws-rds/aws-secretmanager): input type of credentials.fromSecret #11033

merged 4 commits into from
Oct 26, 2020

Conversation

dennisseidel
Copy link
Contributor

Fixes #11015

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 22, 2020 •
edited
Loading

@dennisseidel dennisseidel changed the title fix: input type of credentials.fromsecret fix(aws-secretmanager): input type of credentials.fromsecret Oct 22, 2020
@dennisseidel dennisseidel changed the title fix(aws-secretmanager): input type of credentials.fromsecret fix(aws-rds/aws-secretmanager): input type of credentials.fromsecret Oct 22, 2020
@skinny85 skinny85 self-assigned this Oct 22, 2020
@skinny85 skinny85 changed the title fix(aws-rds/aws-secretmanager): input type of credentials.fromsecret fix(aws-rds/aws-secretmanager): input type of credentials.fromSecret Oct 22, 2020
@skinny85 skinny85 added the pr/do-not-merge This PR should not be merged at this time. label Oct 22, 2020
@skinny85 skinny85 requested a review from njlynch October 22, 2020 23:01
skinny85
skinny85 approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Tagging @njlynch , who's the owner of SecretsManager and the author of this code in RDS.

Nick, you mind taking a look? Thanks!

@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Oct 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a6261d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 35ad608 into aws:master Oct 26, 2020
@ryparker ryparker mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-rds] type for input parameter for rds.Credentials.fromSecret should be ISecret
4 participants
@dennisseidel @aws-cdk-automation @skinny85 @njlynch