Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rds): Minor fix for DatabaseInstance and DatabaseCluster examples in RDS docs #11044

Merged
merged 2 commits into from
Oct 22, 2020
Merged

chore(rds): Minor fix for DatabaseInstance and DatabaseCluster examples in RDS docs #11044

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4262596
chore(rds): Minor fix for DatabaseInstance and DatabaseCluster exampl…
robertd Oct 22, 2020
541939f
Merge branch 'master' into robertd/fix-rds-docs
mergify[bot] Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-rds/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ your instances will be launched privately or publicly:
```ts
const cluster = new rds.DatabaseCluster(this, 'Database', {
engine: rds.DatabaseClusterEngine.auroraMysql({ version: rds.AuroraMysqlEngineVersion.VER_2_08_1 }),
masterUser: rds.Credentials.fromUsername('clusteradmin'), // Optional - will default to admin
credentials: rds.Credentials.fromUsername('clusteradmin'), // Optional - will default to admin
instanceProps: {
// optional , defaults to t3.medium
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE2, ec2.InstanceSize.SMALL),
Expand Down Expand Up @@ -70,7 +70,7 @@ const instance = new rds.DatabaseInstance(this, 'Instance', {
engine: rds.DatabaseInstanceEngine.oracleSe2({ version: rds.OracleEngineVersion.VER_19_0_0_0_2020_04_R1 }),
// optional, defaults to m5.large
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.SMALL),
masterUsername: rds.Credentials.fromUsername('syscdk'), // Optional - will default to admin
credentials: rds.Credentials.fromUsername('syscdk'), // Optional - will default to admin
vpc,
vpcSubnets: {
subnetType: ec2.SubnetType.PRIVATE
Expand Down