feat(apigateway): default value for enum type in schema models #11064
Conversation
Add default to JsonSchema
|
|
|
I assume the unit test is failing. Can someone help me to understand how to run those pls ? |
|
@nija-at jaii I got the unit test passing :) |
nija-at
added
the
pr-linter/exempt-readme
nija-at
changed the title
| "docs-public-apis:@aws-cdk/aws-apigateway.JsonSchema.default", | ||
| "props-default-doc:@aws-cdk/aws-apigateway.JsonSchema.default", |
There was a problem hiding this comment.
These shouldn't be required if you have a tsdoc and a @default annotation defined.
There was a problem hiding this comment.
thx @nija-at I thought the same but the build was failing without those.
There was a problem hiding this comment.
ah just the default on you mean. Did that thanks 👍
There was a problem hiding this comment.
Neither should be required. One is stating that the property has no documentation and the other is stating that the default is not documented. You have both specified.
There was a problem hiding this comment.
Than the build should fail. I show you.
There was a problem hiding this comment.
Hi @nija-at . Indeed it passed. I am sure it failed before without that two lines. Anyway. Thank you for baring with me :). Cheers
nija-at
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Fixes: #11065
Add default to JsonSchema
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license