Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "feat(apigatewayv2): vpc link and private integrations (#10531)" #11070

Merged
merged 6 commits into from
Oct 23, 2020
Merged

revert: "feat(apigatewayv2): vpc link and private integrations (#10531)" #11070

merged 6 commits into from
Oct 23, 2020

Conversation

shivlaks
Copy link
Contributor

This reverts commit 0537598.

This change requires aws/jsii#2172 to be merged and a jsii upgrade as the usage
of @internal for HttpPrivateIntegration and VpcLinkConfigurationOptions is
causing downstream compilation failures currently.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2020 •
edited
Loading

@shivlaks shivlaks self-assigned this Oct 23, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 23, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@shivlaks shivlaks changed the title Revert "feat(apigatewayv2): vpc link and private integrations (#10531)" revert: "feat(apigatewayv2): vpc link and private integrations (#10531)" Oct 23, 2020
@shivlaks
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Command refresh: success

Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0656c54
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 65be3a0 into master Oct 23, 2020
@mergify mergify bot deleted the shivlaks/revert-apigwatewayv2-integrations branch October 23, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@shivlaks shivlaks

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivlaks @aws-cdk-automation @skinny85