Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cognito): remove unused dependency on nodeunit #11085

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

shivlaks
Copy link
Contributor

tests for the cognito module are in jest and don't need nodeunit


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

tests for the cognito module are in jest and don't need nodeunit
@shivlaks shivlaks added the @aws-cdk/aws-cognito Related to Amazon Cognito label Oct 24, 2020
@shivlaks shivlaks requested a review from a team October 24, 2020 20:39
@shivlaks shivlaks self-assigned this Oct 24, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 24, 2020

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 24, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9c63df1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 75875cc into master Oct 26, 2020
@mergify mergify bot deleted the shivlaks/cognito-nodeunit branch October 26, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants