Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): composite alarm ARN uses wrong separator #11186

Merged
merged 6 commits into from
Nov 9, 2020
Merged

fix(cloudwatch): composite alarm ARN uses wrong separator #11186

merged 6 commits into from
Nov 9, 2020

Conversation

Khufu-I
Copy link
Contributor

@Khufu-I Khufu-I commented Oct 29, 2020

CompositeAlarm ARN separator should be : instead of /

Fixes #11184


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

CompositeAlarm ARN separator should be `:` instead of `/`
@gitpod-io
Copy link

gitpod-io bot commented Oct 29, 2020

@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Nov 2, 2020
@rix0rrr rix0rrr changed the title fix(cloudwatch): composite alarm arn fix(cloudwatch): composite alarm ARN uses wrong separator Nov 2, 2020
rix0rrr
rix0rrr previously approved these changes Nov 2, 2020
@mergify mergify bot dismissed rix0rrr’s stale review November 2, 2020 14:35

Pull request has been modified.

rix0rrr
rix0rrr previously approved these changes Nov 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review November 9, 2020 14:12

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b5ba2d2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3009490 into aws:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloudwatch] Composite Alarm ARN is incorrect
3 participants