fix(stepfunctions-tasks): Athena* APIs have incorrect supported integration patterns #11188
Conversation
|
|
akiym
force-pushed
the
fix-athena-integration-pattern
branch
from
6cbd379
to
cdc34d5
Compare
| @@ -87,7 +87,7 @@ export class AthenaStartQueryExecution extends sfn.TaskStateBase { | |||
| }), | |||
|
|
|||
| ], | |||
| actions: ['athena:getDataCatalog', 'athena:startQueryExecution'], | |||
| actions: ['athena:getDataCatalog', 'athena:startQueryExecution', 'athena:getQueryExecution'], | |||
There was a problem hiding this comment.
can you add the rationale for this addition into the commit body. I didn't see it in there
There was a problem hiding this comment.
added a link of this documentation: https://docs.aws.amazon.com/step-functions/latest/dg/athena-iam.html
akiym
force-pushed
the
fix-athena-integration-pattern
branch
from
cdc34d5
to
ce7c847
Compare
shivlaks
changed the title
mergify
bot
dismissed
shivlaks’s stale review
Pull request has been modified.
akiym
force-pushed
the
fix-athena-integration-pattern
branch
from
ce7c847
to
7f7a9e4
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The changes made by #11045 seem to support
WAIT_FOR_TASK_TOKEN (.waitForTaskToken)but according to the documentation, onlyRequest ResponseandRun a job (.sync)are supported: https://docs.aws.amazon.com/step-functions/latest/dg/connect-athena.htmlcloses #11246
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license