feat(pipelines): ShellScriptAction can configure environment #11229
Conversation
The codebuild image of the ShellScriptAction was hardcoded. Some validation scripts require a different codebuild image. This commit adds a property to the ShellScriptAction class to specify the image, which defaults to linux_4_0 (the current hardcoded value). fixes aws#10919
…nvironment The build environment for the ShellScriptAction is hardcoded and set to LINUX_4_0. This fix allows the build environment to be specified in the ShellScriptAction fixes aws#10919
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
…environment The build environment for the ShellScriptAction is hardcoded and set to LINUX_4_0. This fix allows the build environment to be specified in the ShellScriptAction fixes aws#10919
…ub.com/tdikland/aws-cdk into tdikland/pipelinesvalidationbuildimage
tdikland
changed the title
|
👍 This will also allow setting privileged in the environment. Which will solve my current issue. Thanks for making this :) |
|
@rix0rrr Is there still something I should do to get this merged? It's my first contribution, so I'm not quite sure 😅 |
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The build environment for the ShellScriptAction is hardcoded and set to LINUX_4_0.
This fix allows the build environment to be specified in the ShellScriptAction
fixes #10919
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license