Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): api key not supported for SpecRestApi #11235

Merged
merged 2 commits into from
Nov 6, 2020
Merged

fix(apigateway): api key not supported for SpecRestApi #11235

merged 2 commits into from
Nov 6, 2020

Conversation

ayush987goyal
Copy link
Contributor

fix(apigateway): ApiKey not supported for SpecRestApi

closes #11079


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 31, 2020

@drissamri
Copy link

This would be a great addition so we don't have to go through an usage plan 👍

@nija-at nija-at changed the title fix(apigateway): ApiKey not supported for SpecRestApi fix(apigateway): api key not supported for SpecRestApi Nov 6, 2020
nija-at
nija-at previously requested changes Nov 6, 2020
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one small comment.

@mergify mergify bot dismissed nija-at’s stale review November 6, 2020 14:57

Pull request has been modified.

nija-at
nija-at previously approved these changes Nov 6, 2020
@mergify mergify bot dismissed nija-at’s stale review November 6, 2020 15:52

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3e9b773
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ayush987goyal
Copy link
Contributor Author

@nija-at A re-approval is required since I had to rebase from master for build to succeed.

@mergify
Copy link
Contributor

mergify bot commented Nov 6, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 52da8cb into aws:master Nov 6, 2020
@ayush987goyal ayush987goyal deleted the pr/spec-api-key branch November 6, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-apigateway] ApiKey is not supported for SpecRestApi
4 participants