docs(core): make examples compile #11273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
added
contribution/core
|
|
rix0rrr
requested changes
Nov 10, 2020
Add support in `cdk-build` to actually run `jsii-rosetta --compile --fail` in packages that declare supporting "strict" mode for `jsii-rosetta`. This enables a "quick" feedback loop for detercting "now-invalid" code examples. Turned on this feature on `@aws-cdk/core` and made the necessary adjustements to fixtures and examples so that they now compile.
…trict mode on touched packages
…n in Python docs)
RomainMuller
force-pushed
the
rmuller/rosetta-strict
branch
from
693a08f to
9b9e1d9
Compare
|
(Sorry I had to force-push to remove an un-tangled commit that I separated out to a different PR) |
rix0rrr
approved these changes
Nov 30, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support in
cdk-buildto actually runjsii-rosetta --compile --failin packages that declare supporting "strict" mode for
jsii-rosetta.This enables a "quick" feedback loop for detecting "now-invalid" code
examples.
Turned on this feature on
@aws-cdk/coreand made the necessaryadjustments to fixtures and examples so that they now compile. In
particular:
importstatements implicit from the examples, as they areall moved to the fixture. Imports from the library itself are always
unqualified, and external ones are always qualified.
declarestatements in the fixtures to avoid having to comeup with "real" values that compile. This is way less brittle than actually
coming up with an initializer, especially for external types.
Also turned on this feature on
@aws-cdk/aws-iamand made theajustement to fixtures and examples so that they now compile. In
particular:
@aws-cdk/coreare nominal and un-qualified.Fixes #11624.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license