Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appmesh): change VirtualRouter's Listener to a union-like class #11277

Merged
merged 17 commits into from
Nov 7, 2020
Merged

feat(appmesh): change VirtualRouter's Listener to a union-like class #11277

merged 17 commits into from
Nov 7, 2020

Commits on Nov 3, 2020

  1. refactor(appmesh): changes VirtualRouter to have static listener methods

    Dominic Fezzie committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    c0aed38 View commit details
    Browse the repository at this point in the history

  2. remove comment and check length on listener props

    Dominic Fezzie committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    53d5122 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into refactor/virtualRouterListener

    Dominic Fezzie authored Nov 3, 2020
    Configuration menu
    Copy the full SHA
    0ee787c View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. renames virtual router listener static methods

    Dominic Fezzie committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    ed0474e View commit details
    Browse the repository at this point in the history

  2. refactors the static methods to accept port instead of props

    Dominic Fezzie committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    6ac1fe9 View commit details
    Browse the repository at this point in the history

  3. adds addRoute method back to IVirtualRouter

    Dominic Fezzie committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    526035f View commit details
    Browse the repository at this point in the history

  4. add a test for default configuration

    Dominic Fezzie committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    c50357c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into refactor/virtualRouterListener

    @skinny85
    skinny85 authored Nov 5, 2020
    Configuration menu
    Copy the full SHA
    507f625 View commit details
    Browse the repository at this point in the history

  6. addresses pr feedback

    Dominic Fezzie committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    060a86d View commit details
    Browse the repository at this point in the history

  7. fixes whitespace issue in tests

    Dominic Fezzie committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    c170649 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Merge branch 'master' into refactor/virtualRouterListener

    Dominic Fezzie authored Nov 6, 2020
    Configuration menu
    Copy the full SHA
    b299390 View commit details
    Browse the repository at this point in the history

  2. fixes ecs service extension to use new listener class

    Dominic Fezzie committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    cc00cb4 View commit details
    Browse the repository at this point in the history

  3. rename variable

    Dominic Fezzie committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    4aede95 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. move switch to a private method

    Dominic Fezzie committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    ddbdc9d View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary public fields from VirtualRouterListener

    @skinny85
    skinny85 authored Nov 7, 2020
    Configuration menu
    Copy the full SHA
    41a525e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into refactor/virtualRouterListener

    @mergify
    mergify[bot] authored Nov 7, 2020
    Configuration menu
    Copy the full SHA
    1121c44 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into refactor/virtualRouterListener

    @mergify
    mergify[bot] authored Nov 7, 2020
    Configuration menu
    Copy the full SHA
    004e4bf View commit details
    Browse the repository at this point in the history