chore(pkglint): rule to ensure that only allowed packages are public #11317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
njlynch
reviewed
Nov 5, 2020
njlynch
approved these changes
Nov 5, 2020
eladb
reviewed
Nov 5, 2020
tools/pkglint/lib/rules.ts
Outdated
| */ | ||
| export class V2PublicPackages extends ValidationRule { | ||
| public readonly name = 'v2/public-package'; | ||
| private readonly allowlist = ['aws-cdk-lib', 'cdk', 'aws-cdk', 'awslint']; |
There was a problem hiding this comment.
feels like we are missing some stuff here.... decdk, cdk-dasm come to mind and more. how did we compile this list?
There was a problem hiding this comment.
this is not the final list. it's just a start. we'll adjust as we go.
eladb
approved these changes
Nov 10, 2020
In the v2 branch, most packages are private except a handful. Update the pkglint rule to carry an allowlist on the set of packages that should be private. Prevents accidentally publishing new packages.
nija-at
force-pushed
the
nija-at/pkglint-v2visibility
branch
from
3fe9d35
to
6c73a1c
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the v2 branch, most packages are private except a handful. Update the
pkglint rule to carry an allowlist on the set of packages that should be
private.
Prevents accidentally publishing new packages.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license