Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apigatewayv2): move lambda and http proxy integrations to the 'integrations' module #11339

Merged
merged 4 commits into from
Nov 9, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 6, 2020

We now have a @aws-cdk/aws-apigatewayv2-integrations module that is
intended to hold all integration of HTTP APIs with other services.

In line with this, move LambdaProxyIntegration and
HttpProxyIntegration classes to this module.

BREAKING CHANGE: LambdaProxyIntegration and HttpProxyIntegration
classes have moved to the @aws-cdk/aws-apigatewayv2-integration module.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…integrations' module

We now have a `@aws-cdk/aws-apigatewayv2-integrations` module that is
intended to hold all integration of HTTP APIs with other services.

In line with this, move `LambdaProxyIntegration` and
`HttpProxyIntegration` classes to this module.

BREAKING CHANGES: `LambdaProxyIntegration` and `HttpProxyIntegration`
classes have moved to the `@aws-cdk/aws-apigatewayv2-integration` module.
@nija-at nija-at requested a review from a team November 6, 2020 16:09
@nija-at nija-at self-assigned this Nov 6, 2020
@gitpod-io
Copy link

gitpod-io bot commented Nov 6, 2020

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 6, 2020
@ayush987goyal
Copy link
Contributor

I was about to implement it :D

@nija-at
Copy link
Contributor Author

nija-at commented Nov 6, 2020

I was about to implement it :D

Haha. Sorry, I wasn't aware.

@ayush987goyal
Copy link
Contributor

@nija-at Could we please update the README of the integration package with these new integrations? Also, there is one nested header issue in README of the apigatewayv2 module readme here which we can probably add here.

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Nov 6, 2020
@nija-at
Copy link
Contributor Author

nija-at commented Nov 9, 2020

@nija-at Could we please update the README of the integration package with these new integrations? Also, there is one nested header issue in README of the apigatewayv2 module readme here which we can probably add here.

Good call. Updated the README.

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d0c8ce6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 17611d6 into master Nov 9, 2020
@mergify mergify bot deleted the nija-at/apigwv2-moveintegrations branch November 9, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants