chore: do not login to DockerHub #11358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iliapolo
commented
Nov 9, 2020
eladb
approved these changes
Nov 10, 2020
eladb
previously requested changes
Nov 10, 2020
Comment on lines
-9
to
-10
| - nohup /usr/bin/dockerd --host=unix:///var/run/docker.sock --host=tcp://127.0.0.1:2375 --storage-driver=overlay2& | ||
| - timeout 15 sh -c "until docker info; do echo .; sleep 1; done" |
There was a problem hiding this comment.
Aren't these still needed to start the docker daemon?
There was a problem hiding this comment.
@eladb We decided to move this into the ecr proxy image as well - so no. the start.sh script takes care of it.
There was a problem hiding this comment.
I'll add a comment and maybe later we can think about renaming/exposing another script to make it more clear.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk/aws-lambda-nodejs: FAIL test/bundling.test.js (78.783 s)
@aws-cdk/aws-lambda-nodejs: â—� Parcel bundling
@aws-cdk/aws-lambda-nodejs: SyntaxError: Unexpected end of JSON input
@aws-cdk/aws-lambda-nodejs: at JSON.parse (<anonymous>)
@aws-cdk/aws-lambda-nodejs: 21 | this.pkgPath = path.join(pkgPath, 'package.json');
@aws-cdk/aws-lambda-nodejs: 22 | this.pkg = fs.readFileSync(this.pkgPath);
@aws-cdk/aws-lambda-nodejs: > 23 | this.pkgJson = JSON.parse(this.pkg.toString());
@aws-cdk/aws-lambda-nodejs: | ^
@aws-cdk/aws-lambda-nodejs: 24 | }
@aws-cdk/aws-lambda-nodejs: 25 |
@aws-cdk/aws-lambda-nodejs: 26 | /**
@aws-cdk/aws-lambda-nodejs: at new PackageJsonManager (lib/package-json-manager.ts:23:25)
@aws-cdk/aws-lambda-nodejs: at Function.parcel (lib/bundling.ts:141:32)
@aws-cdk/aws-lambda-nodejs: at Object.<anonymous>.test (test/bundling.test.ts:31:12)This sure looks like a race condition... |
NetaNir
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/aws/cdk-ops/pull/887 (Will fail until this is merged)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license