chore(ubergen): switch to ubergen.exclude as a filter instead of private

[nija-at]

Currently, ubergen excludes packages that are marked as 'private'.
In v2, all packages under @aws-cdk/ will be marked as 'private'.
This will mean that 'monocdk' and 'aws-cdk-lib' modules will have no
packages included.

Introduce another field ubergen.exclude in package.json that will be
explicitly exclude packages from the monolithic modules.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[NetaNir]

Adding the exclude in every package makes it hard to track which package should be included in monocdk and which shouldn't. I would suggest adding an array of all excluded packages in ubergen so there will be one centralized location to track these.

[nija-at]

Adding the exclude in every package makes it hard to track which package should be included in monocdk and which shouldn't. I would suggest adding an array of all excluded packages in ubergen so there will be one centralized location to track these.

I don't see the value of creating another location for this configuration. This is where we put package configuration.
To find the list of packages excluded, a simple grep or find + grep will get you what you need.
This is not different from what we have currently.

[rix0rrr]

I don't necessarily mind, but isn't this exclude list better suited in the package.json of aws-cdk-lib itself?

[nija-at]

I don't necessarily mind, but isn't this exclude list better suited in the package.json of aws-cdk-lib itself?

Maybe. It's not clear.
This will have to be 2 lists - one in aws-cdk-lib and one in monocdk, unless we special case monocdk on the v2 branch to not fail if it didn't match any packages.
It might be useful to know if a package is going to be included in ubergen (in the future), so we can enforce any linter or other rules that it must follow at build/test time.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 46ac563
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository