Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 2.0.0a0 is accidentally identified as 0.0.0 by pack script #11389

Merged
merged 2 commits into from
Nov 10, 2020
Merged

chore: 2.0.0a0 is accidentally identified as 0.0.0 by pack script #11389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99d872f
chore: 2.0.0a0 is accidentally identified as 0.0.0 by pack script (#1…
Nov 10, 2020
79e4777
Merge branch 'master' into benisrae/backport/pack-fix
mergify[bot] Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ cp ${changelog_file} ${distdir}/CHANGELOG.md
# defensive: make sure our artifacts don't use the version marker (this means
# that "pack" will always fails when building in a dev environment)
# when we get to 10.0.0, we can fix this...
if find dist/ | grep "${marker}"; then
if find dist/ | grep -F "${marker}"; then
echo "ERROR: build artifacts use the version marker '${marker}' instead of a real version."
echo "This is expected for builds in a development environment but should not happen in CI builds!"
exit 1
Expand Down