Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): dead letter queue for Lambda Targets #11617

Merged
merged 15 commits into from
Mar 3, 2021
Merged

feat(events): dead letter queue for Lambda Targets #11617

merged 15 commits into from
Mar 3, 2021

Conversation

DaWyz
Copy link
Contributor

@DaWyz DaWyz commented Nov 22, 2020 •
edited
Loading

Add DLQ Configuration to Rule targets. Using a DLQ on a rule prevents the application to loose events after all retry attempts are exhausted.

Resolves #11612

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 22, 2020 •
edited
Loading

@SomayaB SomayaB added the pr/work-in-progress This PR is a draft and needs further work. label Nov 23, 2020
@DaWyz DaWyz marked this pull request as ready for review November 26, 2020 18:26
shivlaks
shivlaks previously requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaWyz - i know it's still in progress, but i took a quick first pass - this will be a really useful feature for users!

packages/@aws-cdk/aws-events-targets/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/lambda.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/lambda.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/util.ts Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/util.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/util.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed shivlaks’s stale review December 3, 2020 06:48

Pull request has been modified.

@DaWyz
Copy link
Contributor Author

DaWyz commented Dec 3, 2020

@shivlaks I updated the code to fix the comments. Let me know if it fine. I think it's pretty close to ready. Waiting for your comments/suggestions if you think I should change/add more things !

@DaWyz DaWyz requested a review from shivlaks December 6, 2020 05:22
@shivlaks
Copy link
Contributor

@DaWyz sorry I didn't realize this one was ready for review. Will get through it today!!

@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Dec 29, 2020
@davecap
Copy link

davecap commented Jan 4, 2021

New to CDK here, but interested in this feature. Possibly a dumb question but does this support using the same DLQ for multiple targets?

@DaWyz
Copy link
Contributor Author

DaWyz commented Jan 5, 2021

@davecap I would expect it to work but I haven't tried. The code definitely allow it. I would expect CloudFormation to allow it as well but as I said, I haven't tried.

@DaWyz
Copy link
Contributor Author

DaWyz commented Jan 5, 2021

@SomayaB @shivlaks , is there a way to remove the pr/work-in-progress tag as this is waiting for review ? Thanks

@rix0rrr rix0rrr assigned rix0rrr and unassigned shivlaks Jan 13, 2021
@rix0rrr rix0rrr changed the title feat(aws-events): Add DLQ Configuration to Rule Targets feat(aws-events): dead letter queue for Lambda Targets Jan 13, 2021
rix0rrr
rix0rrr previously approved these changes Jan 13, 2021
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review January 14, 2021 05:59

Pull request has been modified.

@DaWyz DaWyz requested a review from shivlaks January 14, 2021 07:04
This was referenced Mar 8, 2021
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
@DaWyz @cornerwings
feat(events): dead letter queue for Lambda Targets (aws#11617)
bcd5af7 
Add DLQ Configuration to Rule targets. Using a DLQ on a rule prevents the application to loose events after all retry attempts are exhausted.

Resolves aws#11612 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 10, 2021
Closed
Closed
Closed
@gregwebs gregwebs mentioned this pull request Jul 13, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thantos thantos thantos left review comments

@rix0rrr rix0rrr rix0rrr approved these changes

@shivlaks shivlaks Awaiting requested review from shivlaks

Assignees

@rix0rrr rix0rrr

@shivlaks shivlaks

Labels
@aws-cdk/aws-events Related to CloudWatch Events pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-events] Add support for Rule Dead Letter Queue
8 participants
@DaWyz @shivlaks @davecap @aws-cdk-automation @thantos @rix0rrr @nija-at @SomayaB