fix(aws-elasticloadbalancingv2): fix rule dependency #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ALB listener rules are used, the ordering dependency for services that require an attachment to a Load Balancer has to be on the `AWS::ElasticLoadBalancingV2::ListenerRule` object, not on the `Listener` object (as the current implementation does). Fixes #1160.
eladb
approved these changes
Nov 14, 2018
| @@ -250,9 +250,20 @@ export abstract class BaseTargetGroup extends cdk.Construct implements ITargetGr | |||
|
|
|||
| /** | |||
| * Return an object to depend on the listeners added to this target group | |||
| * | |||
| * @deprecated Use 'loadBalancerDependency' instead. | |||
| * | ||
| * @deprecated Use 'loadBalancerDependency' instead. | ||
| */ | ||
| public loadBalancerDependency(): cdk.IDependable { |
There was a problem hiding this comment.
I guess. I didn't want to cause yet another BREAKING CHANGE. But sure.
BREAKING CHANGE: `targetGroup.listenerDependency()` has been renamed to `targetGroup.loadBalancerDependency()`.
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ALB listener rules are used, the ordering dependency for services
that require an attachment to a Load Balancer has to be on the
AWS::ElasticLoadBalancingV2::ListenerRuleobject, not on theListenerobject (as the current implementation does).Fixes #1160.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.