-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-elasticloadbalancingv2): add metrics #1173
Conversation
Add `metricsXxx()` methods to construct Metric objects for the metrics exposed by Application and Network Load Balancers. Fixes #853.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love our metrics API...
Makes me wonder if we can use some code generation...
} | ||
|
||
/** | ||
* The total number of concurrent TCP connections active from clients to the load balancer and from the load balancer to targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap (I use Rewrap for VSCode, and it's awesomer than life)
public readonly targetGroupLoadBalancerArns: string[]; | ||
|
||
/** | ||
* Full name of first load balancer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment why would that be useful to a user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly just useful for metrics and for autoscaling (which probably also uses it to access the metrics)
@@ -0,0 +1,21 @@ | |||
#!/bin/bash | |||
# Script to clean stale .js and .d.ts files (that don't have a corresponding .ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list in CONTRIBUTING?
Add
metricsXxx()
methods to construct Metric objects for the metrics exposedby Application and Network Load Balancers.
Fixes #853.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.