Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-elasticloadbalancingv2): add metrics #1173

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 14, 2018

Add metricsXxx() methods to construct Metric objects for the metrics exposed
by Application and Network Load Balancers.

Fixes #853.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Rico Huijbers and others added 2 commits November 14, 2018 13:44
Add `metricsXxx()` methods to construct Metric objects for the metrics exposed
by Application and Network Load Balancers.

Fixes #853.
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love our metrics API...

Makes me wonder if we can use some code generation...

}

/**
* The total number of concurrent TCP connections active from clients to the load balancer and from the load balancer to targets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap (I use Rewrap for VSCode, and it's awesomer than life)

public readonly targetGroupLoadBalancerArns: string[];

/**
* Full name of first load balancer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment why would that be useful to a user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly just useful for metrics and for autoscaling (which probably also uses it to access the metrics)

@@ -0,0 +1,21 @@
#!/bin/bash
# Script to clean stale .js and .d.ts files (that don't have a corresponding .ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list in CONTRIBUTING?

@rix0rrr rix0rrr merged commit 68d481d into master Nov 15, 2018
@rix0rrr rix0rrr deleted the huijbers/elbv2-metrics branch November 15, 2018 14:09
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ELBv2: expose metrics objects
3 participants