fix(apigateway): base path url cannot contain upper case characters #11799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-apigateway
|
Hi @nija-at. Do you know when this PR will be reviewed? This bug is a blocker on our end. |
nija-at
previously requested changes
Dec 7, 2020
nija-at
changed the title
nija-at
reviewed
Dec 9, 2020
packages/@aws-cdk/aws-apigateway/test/base-path-mapping.test.ts
Outdated
Show resolved
Hide resolved
nija-at
previously approved these changes
Dec 9, 2020
nija-at
reviewed
Dec 9, 2020
packages/@aws-cdk/aws-apigateway/test/base-path-mapping.test.ts
Outdated
Show resolved
Hide resolved
nija-at
approved these changes
Dec 9, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
…ws#11799) We're migrating an existing API Gateway application to CDK and have [hit this error](https://github.com/aws/aws-cdk/blob/2f0a598720f7ecf4dfea7dde97182940fcbe8d9a/packages/%40aws-cdk/aws-apigateway/lib/base-path-mapping.ts#L52), because our base paths include capitalised characters. This PR resolves that issue and I've included some basics tests for the `BasePathMapping` resource. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're migrating an existing API Gateway application to CDK and have hit this error, because our base paths include capitalised characters.
This PR resolves that issue and I've included some basics tests for the
BasePathMappingresource.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license