chore: change "already bootstrapped" message #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous wording, with the word "fully" in it and the exclamation mark at the end, sounded vaguely accusatory. To my (admittedly non-native speaking) senses, the exchange feels akin to this: ``` $ cdk do-something Didn't you know? It's already COMPLETELY done, silly! ``` Instead of just always saying "successfully bootstrapped", I do want to keep a sense of "nothing has been done" in there, to avoid giving some potential subset of people the false impression that they need to do `bootstrap+deploy` every time. This is my stab at an alternative wording.
RomainMuller
approved these changes
Nov 15, 2018
packages/aws-cdk/bin/cdk.ts
Outdated
| @@ -281,8 +281,8 @@ async function initCommandLine() { | |||
| success(' ⏳ Bootstrapping environment %s...', colors.blue(environment.name)); | |||
| try { | |||
| const result = await bootstrapEnvironment(environment, aws, toolkitStackName, roleArn); | |||
| const message = result.noOp ? ' ✅ Environment %s was already fully bootstrapped!' | |||
| : ' ✅ Successfully bootstrapped environment %s!'; | |||
| const message = result.noOp ? ' ✅ Environment %s already bootstrapped, nothing to do.' | |||
There was a problem hiding this comment.
would tend to shift the "nothing to do" upfront (it's the main info, I guess at this point).
Nothing to do: environment %s was already bootstrapped.
You might want to also apply the same polish to the deployment messaging (they are based off a very similar template).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous wording, with the word "fully" in it and the exclamation mark at the end, sounded vaguely accusatory.
To my (admittedly non-native speaking) senses, the exchange feels akin to this:
Instead of just always saying "successfully bootstrapped", I do want to keep a sense of "nothing has been done" in there, to avoid giving some potential subset of people the false impression that they need to do
bootstrap+deployevery time.This is my stab at an alternative wording.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.